Closed sanposhiho closed 1 month ago
Attention: Patch coverage is 76.92308%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 65.75%. Comparing base (
9565863
) to head (32f9203
). Report is 17 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/gatewayapi/clustersettings.go | 76.92% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
hey can you run make generate
and commit those changes ?
oops, done 🙏
can you re run make generate
and commit those changes @sanposhiho , looks like you will not be able to add a custom comment like # Overwritten by the request timeout in HTTPRoute
since it breaks the test generation check
Well, I ran make manifests
and solved some parts of the CI failure. But, looks like I still need to run something else additionally.
@arkodg Now it's fixed! (looks like I needed rebase + make manifests
)
What type of PR is this?
What this PR does / why we need it:
implement RequestTimeout in BackendTrafficPolicy
Which issue(s) this PR fixes:
Fixes #3251