envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

feat: implement RequestTimeout in BackendTrafficPolicy #4329

Closed sanposhiho closed 1 month ago

sanposhiho commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

implement RequestTimeout in BackendTrafficPolicy

Which issue(s) this PR fixes:

Fixes #3251

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (9565863) to head (32f9203). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 76.92% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4329 +/- ## ========================================== - Coverage 65.77% 65.75% -0.02% ========================================== Files 200 200 Lines 24141 24149 +8 ========================================== + Hits 15878 15879 +1 - Misses 7133 7136 +3 - Partials 1130 1134 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkodg commented 1 month ago

hey can you run make generate and commit those changes ?

sanposhiho commented 1 month ago

oops, done 🙏

arkodg commented 1 month ago

can you re run make generate and commit those changes @sanposhiho , looks like you will not be able to add a custom comment like # Overwritten by the request timeout in HTTPRoute since it breaks the test generation check

sanposhiho commented 1 month ago

Well, I ran make manifests and solved some parts of the CI failure. But, looks like I still need to run something else additionally.

sanposhiho commented 1 month ago

@arkodg Now it's fixed! (looks like I needed rebase + make manifests)