search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

[Gateway API 1.2.0] Add gateway name label #4333

Closed zhaohuabing closed 3 weeks ago

zhaohuabing commented 1 month ago

Implement the Gateway name label pfart of GEP-1762: In Cluster Gateway Deployments

MUST label all generated resources (Service, Deployment, etc) with gateway.networking.k8s.io/gateway-name: my-gateway (where my-gateway is the name of the Gateway resource).

This PR only covers the gateway name label requirement in the GEP-1762.

Please note that this label has not been added to the generated resources of the merged gateway.

Implement: https://github.com/envoyproxy/gateway/issues/4330

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.98%. Comparing base (14830c7) to head (f9a6381).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4333 +/- ## ========================================== + Coverage 65.96% 65.98% +0.01% ========================================== Files 197 197 Lines 23959 23971 +12 ========================================== + Hits 15805 15817 +12 Misses 7027 7027 Partials 1127 1127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkodg commented 1 month ago

Apart from passing the conformance test, how does the end user benefit from this change ?

zhaohuabing commented 1 month ago

Apart from passing the conformance test, how does the end user benefit from this change ?

No, but we could replace the existing gateway.envoyproxy.io/owning-gateway-name with this one in the next release.

arkodg commented 1 month ago

I suggest waiting until https://github.com/kubernetes-sigs/gateway-api/issues/3366 is resolved which in indirectly related to the name of the label