search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

Support BandwidthLimiting #4338

Open bjlhlin opened 1 month ago

bjlhlin commented 1 month ago

What type of PR is this?

feat:Support BandwidthLimiting

What this PR does / why we need it: Support BandwidthLimiting

Which issue(s) this PR fixes:

Fixes #4328

zhaohuabing commented 1 month ago

@bjlhlin thanks for working on this!

I think we don't need a standalone BandwidthLimitPolicy for this. BandwidthLimiting can be incorporated into the BackendTrafficPolicy, similar to RateLimit.

additionally, please submit an API PR first. Reaching consensus on the API before implementation can save your time and prevent potential misdirection in the implementation process.

zhaohuabing commented 1 month ago

@bjlhlin could you please remove the implementation part and only leave the API?

Implementation can be added in a follow-up PR.

Thanks!

github-actions[bot] commented 2 weeks ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!