envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

fix debug level logging for IR #4584

Closed arkodg closed 2 weeks ago

arkodg commented 2 weeks ago

https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details

V(1) is equivalent to Zap's DebugLevel

Now after setting the log level to default: debug

I see

2024-10-31T01:59:31.138Z    DEBUG   gateway-api runner/runner.go:176    {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}}   {"runner": "gateway-api", "infra-ir": "default/eg"}
2024-10-31T01:59:31.138Z    DEBUG   gateway-api runner/runner.go:187    {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]}  {"runner": "gateway-api", "xds-ir": "default/eg"}

Relates to https://github.com/envoyproxy/gateway/pull/4505

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.50%. Comparing base (b0c6f8c) to head (97e679d). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4584 +/- ## ========================================== + Coverage 65.47% 65.50% +0.02% ========================================== Files 211 211 Lines 31858 31854 -4 ========================================== + Hits 20859 20865 +6 + Misses 9755 9748 -7 + Partials 1244 1241 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zirain commented 2 weeks ago

/retest