search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.63k stars 352 forks source link

Set ignore_health_on_host_removal to true for static clusters #4612

Closed arkodg closed 1 week ago

arkodg commented 2 weeks ago

Removes the endpoint from the pool faster instead of waiting for the result of the active health check. Since the control plane already has definitive endpoint health info from the EndpointSlice API, it's safe to set this.

Fixes: https://github.com/envoyproxy/gateway/issues/4564

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.47%. Comparing base (a88e6eb) to head (617f384). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4612 +/- ## ========================================== + Coverage 65.43% 65.47% +0.03% ========================================== Files 211 211 Lines 31904 31907 +3 ========================================== + Hits 20876 20890 +14 + Misses 9782 9775 -7 + Partials 1246 1242 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkodg commented 1 week ago

LGTM. @arkodg the title should be "Set ignore_health_on_host_removal to true for dynamic clusters" ?

Static here is static endpoints delivered by EDS

zhaohuabing commented 1 week ago

Oh I see. Thanks for the explaination.

nezdolik commented 1 week ago

lgtm