search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.64k stars 354 forks source link

Only the last `EnvoyProxy` will be used as the OIDC name doesn't include the cluster index #4720

Open zhaohuabing opened 1 week ago

zhaohuabing commented 1 week ago

Rethinking on this, since EnvoyProxy is an optional parameter, its name may not be suitable to be used as part of the generated cluster name. We can always use EndpointRoutingType for OIDC, ExtProc, and other none-route backend clusters and don't need to use the RoutingType in the EnvoyProxy.

Discussed this with @arkodg and @guydc on the EG meeting this week, we still want to respect the routingType in EnvoyProxy configuration for Service Mesh integration and LB policy.

Originally commented by @zhaohuabing on: https://github.com/envoyproxy/gateway/pull/4707#discussion_r1847787969