search

envoyproxy / gateway

Manages Envoy Proxy as a Standalone or Kubernetes-based Application Gateway
https://gateway.envoyproxy.io
Apache License 2.0
1.64k stars 354 forks source link

Support configuring envoyproxy infra attributes in the Helm chart #4764

Open Xunzhuo opened 3 days ago

Xunzhuo commented 3 days ago

Description:

Describe the desired behavior, what scenario it enables and how it would be used.

In vendor, it has some scenarios for configuring envoyproxies attributes. It would be nice to configure all the envoyproxy knobs in the helm chart.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

arkodg commented 3 days ago

+1 to this, a envoyProxy / envoyProxyTemplate field could be added to https://github.com/envoyproxy/gateway/blob/71c0b5408f7f80ef8b9d1e0bcf511891839edecd/api/v1alpha1/envoygateway_types.go#L154

This now introduces 3 levels of EnvoyProxy configuration (EnvoyGateway, EnvoyProxy attached to GatewayClass, EnvoyProxy attached to Gateway) The current merge Strategy is Replace and most specific one wins, so if the admin set the image value at top level it will be overridden if any other value is set in the lower level EnvoyProxy (all fields are replaced today)

There is the Merge Strategy option tracked with https://github.com/envoyproxy/gateway/issues/1934