search

envoyproxy / go-control-plane

Go implementation of data-plane-api
Apache License 2.0
1.48k stars 505 forks source link

Bump vtprotobuf import #914

Closed howardjohn closed 2 months ago

howardjohn commented 2 months ago

Goes along with https://github.com/envoyproxy/envoy/pull/33365. This will be required to pull in that Envoy change, but it can merge before it.

howardjohn commented 2 months ago

LGTM Out of curiosity, is there a reason to not provide unmarshal in the protobuf generation? It would remain conditioned under the build tag, and it would be quite useful for people implementing services like sds or ext_authz servers to be able to use vtprotobuf also on the unmarshaling path for performance reasons

I wouldn't mind adding it, mostly excluded since it wasn't terribly important to us and there were already concerns about binary size.

This would need a change to envoyproxy/envoy

howardjohn commented 2 months ago

@valerian-roche the Envoy PR landed. I think that means the sync job will be broken until this lands