envoyproxy / go-control-plane

Go implementation of data-plane-api
Apache License 2.0
1.48k stars 505 forks source link

Goroutine leak in DeltaStreamHandler: fix for issue 913: #916

Closed zhiyanfoo closed 2 months ago

zhiyanfoo commented 2 months ago

This PR adds a unit test for the go routine leak identified in issue 913. The bug fix is simply to re-use the same logic that already exists for the state-of-the-world StreamHandler.

You can re-create the goroutine leak by running the commit with just the test, and seeing that it fails before the fix.