search

envoyproxy / go-control-plane

Go implementation of data-plane-api
Apache License 2.0
1.48k stars 505 forks source link

xds server: Update reference/resource checks for DefaultFilterChain #949

Closed sfc-gh-randerson closed 3 weeks ago

sfc-gh-randerson commented 1 month ago

This updates the consistency check to also consider the "DefaultFilterChain" in addition to the list of filter chains.

sfc-gh-randerson commented 3 weeks ago

Minor comment only Tbh this code is not really maintained and very likely out of sync with envoy which has evolved on supporting partial snapshots. Can you confirm if you rely on this functionality? My long term goal is to fully remove this logic as it is imo out of place and is also creating issues to support other data-planes (for instance grpc libraries)

By "this code", do you mean the resource/reference check part of cache.Snapshot? Or something more broad?

We are setting ads=true when we call NewSnapshotCache() which seems to imply that our snapshots have to be consistent, which is what prompted this change. We can probably change away from that, but there's not really an indication right now that it's discouraged.