envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

Fix bug: the DiscoveryRequest with resource names may never be updated if xDS server is restarted with empty SnapshotCache #103

Closed PinZhang closed 5 years ago

PinZhang commented 5 years ago

The problem could be reproduced by following the steps:

codecov-io commented 5 years ago

Codecov Report

Merging #103 into master will decrease coverage by 0.08%. The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #103      +/-   ##
===========================================
- Coverage     93.88%   93.8%   -0.09%     
- Complexity      140     141       +1     
===========================================
  Files            17      17              
  Lines           540     549       +9     
  Branches         46      47       +1     
===========================================
+ Hits            507     515       +8     
- Misses           25      26       +1     
  Partials          8       8
Impacted Files Coverage Δ Complexity Δ
.../io/envoyproxy/controlplane/cache/SimpleCache.java 95.61% <92.3%> (-0.58%) 30 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 450d0b3...dd416f7. Read the comment docs.

PinZhang commented 5 years ago

@joeyb Could you please review this patch? thanks.

PinZhang commented 5 years ago

@joeyb The patch has been updated by following your feedback, please help review again, thanks.