search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

build: deprecate envoy-java-control-plane-bot #109

Closed joeyb closed 5 years ago

joeyb commented 5 years ago

Similar to the protoc-gen-validate build, use the shared envoy-bot user rather than our envoy-java-control-plane-bot user.

Signed-off-by: Joey Bratton jbratton@salesforce.com

codecov-io commented 5 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage     92.88%   92.88%           
  Complexity      150      150           
=========================================
  Files            19       19           
  Lines           576      576           
  Branches         48       48           
=========================================
  Hits            535      535           
  Misses           32       32           
  Partials          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e19277...2faf28f. Read the comment docs.

joeyb commented 5 years ago

@rmichela - When you get a chance, can you take a look at this and let me know if you think there is anything else I need to change to bring this build in line with how protoc-gen-validate does its deployments? I've already updated all of the GPG_*/SONATYPE_* env vars in CircleCI.

rmichela commented 5 years ago

I think it should "just work".