search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

Make some info logs debug #112

Closed sschepens closed 5 years ago

sschepens commented 5 years ago

Some info logs seem like they should be debug, they are very verbose.

codecov-io commented 5 years ago

Codecov Report

Merging #112 into master will decrease coverage by 2.55%. The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
- Coverage     92.88%   90.32%   -2.56%     
  Complexity      150      150              
============================================
  Files            19       19              
  Lines           576      579       +3     
  Branches         48       51       +3     
============================================
- Hits            535      523      -12     
- Misses           32       44      +12     
- Partials          9       12       +3
Impacted Files Coverage Δ Complexity Δ
...nvoyproxy/controlplane/server/DiscoveryServer.java 96.03% <100%> (ø) 14 <0> (ø) :arrow_down:
.../io/envoyproxy/controlplane/cache/SimpleCache.java 82.9% <6.25%> (-12.71%) 30 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9579c75...dfad8a0. Read the comment docs.

jakubdyszkiewicz commented 5 years ago

I'd agree with this. There are so many logs on INFO level that we switched DiscoveryServer and SimpleCache to WARN in our environment.

What do you think @snowp ? Do you log all of this at Square?

snowp commented 5 years ago

We log everything but rarely look at it, so I'd be okay with bumping the level