Closed sschepens closed 5 years ago
Merging #113 into master will decrease coverage by
0.32%
. The diff coverage is88.57%
.
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 90.32% 90% -0.33%
+ Complexity 150 149 -1
==========================================
Files 19 19
Lines 579 560 -19
Branches 51 51
==========================================
- Hits 523 504 -19
Misses 44 44
Partials 12 12
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...envoyproxy/controlplane/cache/CacheStatusInfo.java | 100% <100%> (ø) |
9 <8> (-1) |
:arrow_down: |
.../io/envoyproxy/controlplane/cache/SimpleCache.java | 82.6% <85.18%> (-0.3%) |
30 <3> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b937b37...8cf8768. Read the comment docs.
@snowp @joeyb could one of you take a look at these and see if it makes sense? I'm in the process of trying these changes in our control plane
@jakubdyszkiewicz Mind taking a look at this one?
@jakubdyszkiewicz can u review this please? we've tried it in production without any issues
I'm looking into this, but give me some time I need to properly understand the logic behind this.
@jakubdyszkiewicz made setSnapshot
synchronized and lastWatchRequestTime
volatile, care to review again?
Related to #111