search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

Updated protobuf definitions #118

Closed rene-m-hernandez closed 5 years ago

rene-m-hernandez commented 5 years ago

Updates to latest Envoy API (as of Sept. 13)

Followed these instructions: https://github.com/envoyproxy/java-control-plane#bring-api-up-to-date-with-data-plane-api

rene-m-hernandez commented 5 years ago

When attempting to update to the latest Envoy API definitions, a couple of issues were encountered:

  1. A dependency on a previously unused googleapi proto was added Solved: Modify tools/update-api.sh to copy the missing file
  2. v2 of the Envoy API was copied to v3alpha as part of the UDPA work being done. This is causing a conflict at compilation as multiple proto files will attempt to generate the same Java class. Solved: Added exclude to Maven protoc plugin
codecov-io commented 5 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #118   +/-   ##
========================================
  Coverage      89.5%   89.5%           
  Complexity      193     193           
========================================
  Files            22      22           
  Lines           600     600           
  Branches         48      48           
========================================
  Hits            537     537           
  Misses           48      48           
  Partials         15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8afd4f8...1dbb437. Read the comment docs.

rene-m-hernandez commented 5 years ago

@jakubdyszkiewicz @snowp @joeyb Any chance I can get a review and get a new version cut with this merged?

rene-m-hernandez commented 5 years ago

Thank you for merging @snowp! Any chance we can release a new version with the updated APIs?

snowp commented 5 years ago

Sorry about the delay, let me try to kick off a release