envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane

Apache License 2.0

293 stars 136 forks source link

Update protobuf definitions to v1.12.2 #125

Closed gregeinfrank closed 4 years ago

gregeinfrank commented 4 years ago

Updates to latest Envoy API [v1.12.2] (as of Dec 10, 2019)

Followed the instructions: https://github.com/envoyproxy/java-control-plane#bring-api-up-to-date-with-data-plane-api

codecov-io commented 4 years ago

Codecov Report

Merging #125 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #125   +/-   ##
========================================
  Coverage      89.5%   89.5%           
  Complexity      193     193           
========================================
  Files            22      22           
  Lines           600     600           
  Branches         48      48           
========================================
  Hits            537     537           
  Misses           48      48           
  Partials         15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 046ab2b...2efed00. Read the comment docs.

gregeinfrank commented 4 years ago

@snowp - Please let me know if there's anything else needed here

jakubdyszkiewicz commented 4 years ago

LGTM @gregeinfrank merging to master. Thank you.

gregeinfrank commented 4 years ago

Thanks @jakubdyszkiewicz - can you push a new release for v1.12.2?

gregeinfrank commented 4 years ago

@jakubdyszkiewicz ping -- any idea when we can push a new version?

jakubdyszkiewicz commented 4 years ago

Sorry about the delay. @chemicL @slonka how do you feel about releasing a new version? Can we do it or do you want to also push changes in pending PRs?

slonka commented 4 years ago

I think we can release this, we probably want to release our changes in a separate version.

jakubdyszkiewicz commented 4 years ago

Hey, @gregeinfrank I released java control plane 0.1.21. I'll try to be more responsive next time, but also feel free to ping me on Envoy Slack anytime.

gregeinfrank commented 4 years ago

@jakubdyszkiewicz Thanks. Any idea how to get this up on https://jcenter.bintray.com/com/github/envoy-scala/control-plane/

jakubdyszkiewicz commented 4 years ago

I think this is completely different project (envoy-scala?). This one is available in maven central here https://search.maven.org/artifact/io.envoyproxy.controlplane/java-control-plane/0.1.21/pom