search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

[cluster.proto v3] Update schema to latest version #148

Closed nezdolik closed 3 years ago

nezdolik commented 4 years ago

Currently cluster.proto schema is lagging behind the one available in Envoy repo. Added fields available in envoy v3 cluster api . Made no changes to api v2, as it is being deprecated.

Fields that are currently missing: 

  core.v3.TypedExtensionConfig upstream_config = 48;

  // Configuration to track optional cluster stats.
  TrackClusterStats track_cluster_stats = 49;

  // If `connection_pool_per_downstream_connection` is true, the cluster will use a separate
  // connection pool for every downstream connection
  bool connection_pool_per_downstream_connection = 51;

Could not find any tests for newly added fields, need to come up with approach.

nezdolik commented 4 years ago

ping @slonka @snowp @lukidzi

pzmi commented 4 years ago

Hi @nezdolik! Did you follow the update procedure from the README.md?

nezdolik commented 4 years ago

Hi @pzmi, i did not. Thanks for the hint!

slonka commented 3 years ago

This change is out of date due to https://github.com/envoyproxy/java-control-plane/pull/155. If I'm missing something please reopen.