envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane

Apache License 2.0

293 stars 136 forks source link

Generate Kotlin gRPC Stubs #169

Open t0rr3sp3dr0 opened 3 years ago

t0rr3sp3dr0 commented 3 years ago

This patch modifies build configuration files to generate gRPC Stubs for Kotlin and place them inside the built artifact. The changes were based on official tutorials on how to configure maven-protobuf-plugin to generate Kotlin gRPC Stubs (https://github.com/grpc/grpc-kotlin/tree/master/compiler) and how to build Kotlin with Maven (https://kotlinlang.org/docs/maven.html).

In the built JAR, for each ServiceGrpc class generated from a gRPC service definition on proto files, a new class called ServiceGrpcKt is introduced with the Kotlin interface. I've tested it on a Java-only project to make sure it doesn't cause any problem.

The built artifact is available on JitPack: https://jitpack.io/#t0rr3sp3dr0/java-control-plane/3bd90153d9.

Closes #168

codecov-commenter commented 3 years ago

Codecov Report

Merging #169 (3bd9015) into main (06f2735) will decrease coverage by 0.10%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #169      +/-   ##
============================================
- Coverage     88.26%   88.16%   -0.11%     
+ Complexity      298      297       -1     
============================================
  Files            31       31              
  Lines           980      980              
  Branches         78       78              
============================================
- Hits            865      864       -1     
  Misses           85       85              
- Partials         30       31       +1

Impacted Files	Coverage Δ
.../io/envoyproxy/controlplane/cache/SimpleCache.java	`82.97% <0.00%> (-0.71%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 800cb5e...3bd9015. Read the comment docs.

slonka commented 3 years ago

Hi, I will test it in Envoy-Control and check if it works and if it does i'll review it and merge it.

t0rr3sp3dr0 commented 3 years ago

Hi @slonka! Were you able to verify this works?

slonka commented 3 years ago

Hi @t0rr3sp3dr0 - sorry for the delay. I've run into a bit of a problem, after leaving Allegro I no longer can release SNAPSHOTs of java-control-plane. I'm getting permissions denied. Maybe @lukidzi can help out. I'm using the same token as before, and even created a new one.