search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

Fix flakiness in integration test #213

Closed rulex123 closed 2 years ago

rulex123 commented 2 years ago

A connect timeout value of 0 will cause Envoy to return a proto validation error. The connect timeout value for this specific test is picked at random (with an upper bound only), so to fix we also set a lower bound.

Signed-off-by: rulex123 erica.manno@gmail.com

codecov-commenter commented 2 years ago

Codecov Report

Merging #213 (dc8f272) into main (68f0503) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #213   +/-   ##
=========================================
  Coverage     82.44%   82.44%           
  Complexity      275      275           
=========================================
  Files            31       31           
  Lines           980      980           
  Branches         78       78           
=========================================
  Hits            808      808           
  Misses          137      137           
  Partials         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68f0503...dc8f272. Read the comment docs.