search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

Use the public maven central relase of com.google.api.grpc:proto-goog… #238

Open sfc-gh-pbennes opened 2 years ago

sfc-gh-pbennes commented 2 years ago

…le-common-protos

This fixes an issue of duplicate and possibly incompatible classes for com/google/api and com/google/rpc proto generated classes. If a project includes both api and proto-google-common-protos dependencies, there will be duplicate classes on the class path. This is because:

Similar to the issue in #171 that #237 will fix.

Signed-off-by: Preston Bennes preston.bennes@snowflake.com

codecov-commenter commented 2 years ago

Codecov Report

Merging #238 (b0d8ad6) into main (e5b9700) will decrease coverage by 0.40%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #238      +/-   ##
============================================
- Coverage     82.48%   82.07%   -0.41%     
+ Complexity      275      274       -1     
============================================
  Files            31       31              
  Lines           982      982              
  Branches         78       78              
============================================
- Hits            810      806       -4     
- Misses          137      140       +3     
- Partials         35       36       +1
Impacted Files Coverage Δ
...o/envoyproxy/controlplane/cache/TestResources.java 85.78% <0.00%> (-2.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5b9700...b0d8ad6. Read the comment docs.

sfc-gh-pbennes commented 2 years ago

FWIW I also wanted to remove the other google protos but I couldn't find either the protos or classes in any published jar that looked like it was intentionally publishing them.

slowsoul commented 11 months ago

@sfc-gh-pbennes Thanks for the PR! I recently got into the same issue and found this fix. Can any reviewers help review this PR? Thanks!