search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

cache: Refactor Map usage into Set #28

Closed snowp closed 6 years ago

snowp commented 6 years ago

Instead of using Map<T, Boolean> just use a Set instead. This doesn't affect behavior at all, it's just more idiomatic Java.

Also some variable name renames just to make the code a little bit clearer to read

Signed-off-by: Snow Pettersen snowp@squareup.com

codecov-io commented 6 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage     94.97%   94.97%           
+ Complexity       45       44    -1     
=========================================
  Files             7        7           
  Lines           179      179           
  Branches         15       15           
=========================================
  Hits            170      170           
  Misses            4        4           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
.../io/envoyproxy/controlplane/cache/SimpleCache.java 95% <100%> (ø) 17 <5> (-1) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73448d...a6a311e. Read the comment docs.