search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
291 stars 136 forks source link

Fix workflow failures #311

Closed rulex123 closed 7 months ago

rulex123 commented 7 months ago

The scheduled workflow still fails with the following problem:

[Invalid workflow file: .github/workflows/scheduled.yml#L15](https://github.com/envoyproxy/java-control-plane/actions/runs/7500670890/workflow)
The workflow is not valid. .github/workflows/scheduled.yml (Line: 15, Col: 3): Error calling workflow 'envoyproxy/java-control-plane/.github/workflows/update-protobuf.yml@5286fba8899534d5aeda522dc06209a8cc57d2d3'. The workflow is requesting 'contents: read', but is only allowed 'contents: none'.

It seems that we need to explicitly set the contents scope, otherwise it will default to none.

cc @nezdolik @phlax

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5286fba) 86.16% compared to head (a47ca9b) 86.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================= Coverage 86.16% 86.16% Complexity 361 361 ========================================= Files 42 42 Lines 1178 1178 Branches 97 97 ========================================= Hits 1015 1015 Misses 116 116 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.