envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
291 stars 136 forks source link

Fix update-protobuf workflow (we are getting closer =)) #317

Closed rulex123 closed 7 months ago

rulex123 commented 7 months ago

The update-protobuf workflow is still failing due to lack of permissions on pushing a branch. We need to set contents: write permission according to the documentation here

https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#workflow-permissions

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3eab8e2) 86.16% compared to head (a2b115d) 86.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ========================================= Coverage 86.16% 86.16% Complexity 361 361 ========================================= Files 42 42 Lines 1178 1178 Branches 97 97 ========================================= Hits 1015 1015 Misses 116 116 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.