search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

cache: Store node group in StatusInfo instead of node #36

Closed joeyb closed 6 years ago

joeyb commented 6 years ago

Returning the Node in the StatusInfo doesn't really make sense because it may not be accurate, depending on the NodeGroup implementation. It essentially just returns the first Node that hashed to a given group.

Signed-off-by: Joey Bratton jbratton@salesforce.com

codecov-io commented 6 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.53%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     94.55%   95.08%   +0.53%     
- Complexity       90       91       +1     
============================================
  Files            10       10              
  Lines           367      366       -1     
  Branches         31       31              
============================================
+ Hits            347      348       +1     
  Misses           13       13              
+ Partials          7        5       -2
Impacted Files Coverage Δ Complexity Δ
.../io/envoyproxy/controlplane/cache/SimpleCache.java 100% <100%> (+2.5%) 21 <1> (+2) :arrow_up:
...n/java/io/envoyproxy/controlplane/cache/Watch.java 83.33% <100%> (-0.88%) 7 <0> (-1)
...envoyproxy/controlplane/cache/CacheStatusInfo.java 100% <100%> (ø) 10 <1> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 578719b...9b23c67. Read the comment docs.