search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

test: update ConfigSource to no longer use deprecated config #61

Closed snowp closed 6 years ago

snowp commented 6 years ago

cluster_names is deprecated and should no longer be specified. Latest docker image is failing because of this on master.

[testcontainers-netty-1-2] INFO 🐳 [envoyproxy/envoy-alpine:latest] - STDERR: [2018-07-10 16:40:01.979][18][critical][main] source/server/server.cc:78] error initializing configuration '/tmp/tmp.EjhlgN/envoy.yaml': envoy::api::v2::core::ConfigSource::GRPC must not have a cluster name specified.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b32d5b). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   95.18%           
  Complexity        ?      108           
=========================================
  Files             ?       11           
  Lines             ?      436           
  Branches          ?       39           
=========================================
  Hits              ?      415           
  Misses            ?       14           
  Partials          ?        7
Impacted Files Coverage Δ Complexity Δ
...o/envoyproxy/controlplane/cache/TestResources.java 97.59% <100%> (ø) 7 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b32d5b...7f183f0. Read the comment docs.