Closed lvijay closed 6 years ago
Merging #69 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
Coverage 95.21% 95.21%
Complexity 112 112
=========================================
Files 12 12
Lines 439 439
Branches 38 38
=========================================
Hits 418 418
Misses 14 14
Partials 7 7
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ccc2865...62f684a. Read the comment docs.
Thanks @joeyb. I've updated the .proto files as directed — I rebased because there were merge conflicts between the files I'd manually copied over and the script.
I've also updated the README.
I'm not sure about the version upgrade process followed here but I'm guessing it needs bumping up.
@lvijay - Looks good, thanks! After merging this, I'll kick off deployment of a new version.
This version is up-to-date as of data-plan-api sha 512daa218.
Fixes #68.
Testing done:
mvn verify
on my machine succeeds.