search

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane
Apache License 2.0
293 stars 136 forks source link

server: allow multiple callbacks to be provided #72

Closed snowp closed 6 years ago

snowp commented 6 years ago

This will make it reasonable to provide open source callbacks that can be used alongside user defined callbacks.

codecov-io commented 6 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.87%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
- Coverage     95.22%   94.35%   -0.88%     
+ Complexity      112      110       -2     
============================================
  Files            12       12              
  Lines           440      443       +3     
  Branches         38       38              
============================================
- Hits            419      418       -1     
- Misses           14       18       +4     
  Partials          7        7
Impacted Files Coverage Δ Complexity Δ
...nvoyproxy/controlplane/server/DiscoveryServer.java 97.8% <100%> (+0.07%) 11 <3> (+2) :arrow_up:
.../controlplane/server/DiscoveryServerCallbacks.java 20% <0%> (-80%) 1% <0%> (-4%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce8b646...14f7472. Read the comment docs.