search

envoyproxy / nighthawk

L7 (HTTP/HTTPS/HTTP2/HTTP3) performance characterization tool
Apache License 2.0
361 stars 81 forks source link

Dependency Injection for Logging #290

Open dubious90 opened 4 years ago

dubious90 commented 4 years ago

Our systems that we will be running nighthawk in have their own logging framework that does not seem to inherently work with the envoy logging that nighthawk uses. It would be great if it were possible to have a dependency injection or binary configuration of some sort where we could configure what happens with the Nighthawk logging messages.

oschaaf commented 4 years ago

By chance I just came across some possibly relevant enhancements in Envoy, there seem to be more sink types now.

For example see LogRecordingSink: https://github.com/envoyproxy/envoy/blob/d25fb83ddb85d2de376df3fc91e15e6a3df02091/test/test_common/logging.cc

(This doesn't seem to cover any sort of extension model for this, but this might offer a better alternative to the file log scraping going on today in some of the tests)