envoyproxy / ratelimit

Go/gRPC service designed to enable generic rate limit scenarios from different types of applications.
Apache License 2.0
2.21k stars 428 forks source link

fix(redis): use logger instead of println #606

Closed jwillker closed 1 month ago

jwillker commented 1 month ago

Fix: https://github.com/envoyproxy/ratelimit/issues/605

cc: @envoyproxy/ratelimit-maintainers

mattklein123 commented 1 month ago

I think this might be a real CI issue?

jwillker commented 1 month ago

There is a test that checks if there is panic or not; for different situations, I will maintain the panic and remove the println, so the tests will pass now.