envoyproxy / ratelimit

Go/gRPC service designed to enable generic rate limit scenarios from different types of applications.
Apache License 2.0
2.27k stars 442 forks source link

runner: close rate limiter on Stop #635

Closed birdayz closed 2 months ago

birdayz commented 3 months ago

redis client is never closed, even after graceful shutdown via Stop(). It is possible to observe this by creating a runner, and calling Stop(), and stopping the redis server. Runner is expected to be stopped, and all components closed, however still logs can be seen that redis is unavailable.

this patch allows runner to actually gracefully close rate limit implementations, so all components are closed gracefully on Stop.