envoyproxy / ratelimit

Go/gRPC service designed to enable generic rate limit scenarios from different types of applications.
Apache License 2.0
2.25k stars 440 forks source link

Update example prom-statsd-exporter config #648

Open jcdavis opened 1 month ago

jcdavis commented 1 month ago

Few cleanups for folks using this as a baseline (aka myself):

  1. Remove timer_type for counter metrics, this field is a no-op as-is and is just confusing.
  2. Where it is needed (ratelimit_service_rate_limit_shadow_mode), switch to observer_type, since timer_type has been deprecated since at least 2020: https://github.com/prometheus/statsd_exporter/commit/4a64979563442b948c6b929daee10f3b15493681
  3. Add a single-key shadow mode match (even if this is not necessary/used by the example ratelimit setup)
github-actions[bot] commented 3 weeks ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

ysawa0 commented 3 weeks ago

Looks great. @jcdavis Should we also update the image ver here? https://github.com/envoyproxy/ratelimit/blob/main/docker-compose-example.yml#L13

ysawa0 commented 3 weeks ago

Please fix DCO