Open jcdavis opened 1 month ago
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Looks great. @jcdavis Should we also update the image ver here? https://github.com/envoyproxy/ratelimit/blob/main/docker-compose-example.yml#L13
Please fix DCO
Few cleanups for folks using this as a baseline (aka myself):
timer_type
for counter metrics, this field is a no-op as-is and is just confusing.observer_type
, sincetimer_type
has been deprecated since at least 2020: https://github.com/prometheus/statsd_exporter/commit/4a64979563442b948c6b929daee10f3b15493681