search

envoyproxy / ratelimit

Go/gRPC service designed to enable generic rate limit scenarios from different types of applications.
Apache License 2.0
2.3k stars 451 forks source link

set envconfig DISABLE_STATS true by default #765

Closed johnzheng1975 closed 3 days ago

johnzheng1975 commented 1 week ago

Fix issue: https://github.com/envoyproxy/ratelimit/issues/764

johnzheng1975 commented 6 days ago

@junr03 , FYI. I think had better set envconfig DISABLE_STATS true by default, how do you think? Thanks.

zirain commented 3 days ago

I believe it's better to keep the default as before, it's easy for people to change it in real/prod env.

johnzheng1975 commented 3 days ago

That's fine. Close it.