search

envy / esp-knx-ip

A KNX/IP library for the ESP8266 with Arduino
MIT License
136 stars 49 forks source link

Phy and group adresses #3

Closed ghost closed 6 years ago

ghost commented 7 years ago

Hi. I have checked your code and example - great working ! Thank you. One small thing: Please use the standard syntax fpr physical adresses with pots like 0.0.1 in your webpage. Group adresses with slashes like 0/0/1. It makes things more clear :-)

For finalization it would be great to seperate the webserver implementation and the KNX finctionality.

best regards, Peter

envy commented 7 years ago

Hi,

One small thing: Please use the standard syntax fpr physical adresses with pots like 0.0.1 in your webpage. Group adresses with slashes like 0/0/1. It makes things more clear :-)

Will change this with one of the next commits.

For finalization it would be great to seperate the webserver implementation and the KNX finctionality.

I don't know how I want to handle this, yet. My plan was to be able to flash the same firmware onto multiple devices and then configure the GAs in some other way so that they are not hardcoded. My first idea was an application running on a PC sending special UDP packets that would configure the device, but this is too complex. So self-contained configuration via webserver was easiest. I'll probably make it disableable during compile time with a define or something. Maybe one day I can trick the ETS into programming ESPs ;D

ghost commented 7 years ago

Hi envy ! To ctrl and setup the config via webpage is a good way - only to have the webserver implementation and the KNX object in the same files makes it not easy to use it in other projects - i.e if there already a webserver is running. my 5ct :-) In my case I #undefine it - no problem. regards, Peter

envy commented 6 years ago

I changed the notation of physical address in the webserver to dots. I also added the possibility to specify own webserver object, so that the knx system reuses the same webserver as other code. However, I need to add the possibility to specify a prefix for the knx endpoints as to not clash with other endpoints.