enwi / hueplusplus

A simple C++ library to control Philips Hue lights on Linux, MacOS, Windows, Espressif ESP32 SDK and Arduino. Full documentation at
https://enwi.github.io/hueplusplus/
GNU Lesser General Public License v3.0
53 stars 22 forks source link

Remove all uses of implicit conversions from json. #55

Closed Jojo-1000 closed 4 years ago

Jojo-1000 commented 4 years ago

These are prone to breaking in the future or with some compiler versions, so it is better to remove them.

Closes #50

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will decrease coverage by 1.49%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   75.00%   73.50%   -1.50%     
==========================================
  Files          42       42              
  Lines        3853     4813     +960     
==========================================
+ Hits         2890     3538     +648     
- Misses        963     1275     +312     
Impacted Files Coverage Δ
hueplusplus/ExtendedColorHueStrategy.cpp 100.00% <100.00%> (ø)
hueplusplus/ExtendedColorTemperatureStrategy.cpp 100.00% <100.00%> (ø)
hueplusplus/Hue.cpp 76.51% <100.00%> (ø)
hueplusplus/HueLight.cpp 100.00% <100.00%> (ø)
hueplusplus/SimpleBrightnessStrategy.cpp 100.00% <100.00%> (ø)
hueplusplus/SimpleColorHueStrategy.cpp 100.00% <100.00%> (ø)
hueplusplus/SimpleColorTemperatureStrategy.cpp 100.00% <100.00%> (ø)
hueplusplus/test/test_HueLight.cpp 99.39% <100.00%> (ø)
hueplusplus/include/Hue.h 100.00% <0.00%> (ø)
hueplusplus/test/testhelper.h 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ceedfc1...ab4cfb2. Read the comment docs.