Closed Jojo-1000 closed 3 years ago
Merging #67 (bd6ac26) into development (2b776fa) will decrease coverage by
0.18%
. The diff coverage is90.10%
.
@@ Coverage Diff @@
## development #67 +/- ##
===============================================
- Coverage 83.40% 83.22% -0.19%
===============================================
Files 100 100
Lines 8724 8707 -17
===============================================
- Hits 7276 7246 -30
- Misses 1448 1461 +13
Impacted Files | Coverage Δ | |
---|---|---|
include/hueplusplus/APICache.h | 100.00% <ø> (ø) |
|
include/hueplusplus/BaseDevice.h | 100.00% <ø> (ø) |
|
include/hueplusplus/Bridge.h | 100.00% <ø> (ø) |
|
include/hueplusplus/BridgeConfig.h | 100.00% <ø> (ø) |
|
include/hueplusplus/Group.h | 100.00% <ø> (ø) |
|
include/hueplusplus/HueDeviceTypes.h | 100.00% <ø> (ø) |
|
include/hueplusplus/Light.h | 96.62% <ø> (+10.11%) |
:arrow_up: |
include/hueplusplus/Rule.h | 100.00% <ø> (ø) |
|
include/hueplusplus/Scene.h | 100.00% <ø> (ø) |
|
include/hueplusplus/Schedule.h | 100.00% <ø> (ø) |
|
... and 33 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2b776fa...bd6ac26. Read the comment docs.
The Bridge can be given an additional shared state flag. If present, all resources on the bridge use the same json state internally. Otherwise, every object uses a separate json cache.
Advantages of shared state:
Disadvantages:
const Light
may suddenly change its name