search

enwi / hueplusplus

A simple C++ library to control Philips Hue lights on Linux, MacOS, Windows, Espressif ESP32 SDK and Arduino. Full documentation at
https://enwi.github.io/hueplusplus/
GNU Lesser General Public License v3.0
55 stars 22 forks source link

Remove certificate parsing in Entertainment Mode #72

Closed CalcProgrammer1 closed 3 years ago

CalcProgrammer1 commented 3 years ago

I finally got around to updating OpenRGB to pull in the latest version of hueplusplus and was working on getting it building on my GitLab CI under multiple Linux distributions. The certificate parsing in mbedtls wasn't available in older distros, kept getting build errors from undefined symbols. I took this section out of EntertainmentMode.cpp and tested it on multiple platforms and it does not appear to affect Philips Hue communication so I think it is safe to remove. This way the library will build on more distributions.

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (f96ca1a) into master (a78f457) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   80.79%   80.81%   +0.01%     
==========================================
  Files         101      101              
  Lines        9311     9309       -2     
==========================================
  Hits         7523     7523              
+ Misses       1788     1786       -2
Impacted Files Coverage Δ
src/EntertainmentMode.cpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a78f457...f96ca1a. Read the comment docs.