search

enwikipedia-acc / waca

English Wikipedia Account Creation Interface
https://accounts.wmflabs.org/internal.php
The Unlicense
33 stars 43 forks source link

Make `request.useragent` column in database nullable #881

Open FastLizard4 opened 10 months ago

FastLizard4 commented 10 months ago

Currently, the request.useragent column in the database is defined as TEXT NOT NULL, which means that any requests we receive where we don't receive a User-Agent HTTP header will cause an exception and fail. Currently we only see this with requests that appear to be fuzzed for automated scanning or similar, but it's still not an ideal behavior.

To fix, we should make the request.useragent column nullable.

FastLizard4 commented 10 months ago

Note that there's currently a handful of open PRs that make database changes (#852, #854, and #856) so it's probably best for those to get merged in before working on this (or, alternatively, base any change for this issue on the branch for #856).

stwalkerster commented 10 months ago

This is a https://github.com/enwikipedia-acc/waca/labels/good%20first%20issue candidate, as the change required should be very similar to #713

I won't tag it as such yet due to the other stuff pending.