search

enyancc / vscode-ext-color-highlight

Extension adds colored border around css/web colors in the editor
GNU General Public License v3.0
262 stars 83 forks source link

Fix webpack, and update various babel plugins/presets #139

Closed thomcc closed 3 years ago

thomcc commented 3 years ago

So, as mentioned in the "P.S." of #138, I had to fix a couple other issues to actually test this.

In particular, building this caused webpack to complain about setDynamic not being a function. It turned out that babel and friends were outdated, so I updated them. A caveat is that I haven't done JS professionally in a few years, so I only sort of know what I'm doing here. (I'm pretty sure this is at least mostly reasonable, though)

Also, for whatever reason, even after fixing these changes, I needed to move rename dist/extension to dist/dist/extension in the package.json. I uh, can't really explain why things were getting output to dist/dist. Seems weird.

Anyway, it's possible that this was only needed due to my own confusion about how the project was set up. It's also possible that a change was needed, but you'd rather do it a different way instead. In either of these cases (or any other) you can feel free to close this — this is mostly a courtesy.

ferretwithaberet commented 3 years ago

Thank you for your contribution, it seems that output.filename needs to be set to extension.js instead of dist/extension.js, else webpack will build the extension into dist/dist/. I will fix it.

Edit: I am also not that experienced with professionally done JS, but I am trying my best.