search

enyo / node-tvdb

A node library for thetvdb.com
26 stars 12 forks source link

Working implementation of getInfo #5

Closed lobbin closed 11 years ago

lobbin commented 11 years ago

Also contains a setMirror implementation

Perhaps the content of getInfo should be further processed?

enyo commented 11 years ago

Thanks a lot for your pull requests. I'm currently in the studio 24/7 and will have a look at it and merge it in about 2 weeks. Cheers

enyo commented 11 years ago

Ok, I've had a look at it. Looks great. Thanks! As you already said: it would be great if you could process the info object a bit further (I wrote a comment to the file diff) so that series.SeriesName, episode[X].EpisodeName and actor[X].Name are just accessible as name.

I would also prefer that the series index be called tvShow since that's the convention I used.

Do you agree with those changes and can you implement them, or should I?

Thanks again

lobbin commented 11 years ago

Absolutely, I can do the changes. Should I rename within the objects as well? More than the SeriesName, EpisodeName, etc?

enyo commented 11 years ago

Yeah that would be great. All names should be camelized. The IMDB_ID for example should be imdbId. And if a property inside series starts with SeriesXXX, the Series should be removed obviously. TheTVDB has the worst naming "conventions" I've ever seen :)

lobbin commented 11 years ago

There, I committed a few more changes, should look a lot better now. Not sure really which properties from TVDB to include, but I took a few that looked good :)