search

enyo / opentip

Opentip is an open source javascript tooltip based on the protoype framework.
http://www.opentip.org
1.25k stars 401 forks source link

Possible Prototype Adapter Error? #12

Closed donlee8 closed 11 years ago

donlee8 commented 11 years ago

I'm using the prototype adapter and am getting this JS error at line 129 or opentip.js:

Uncaught TypeError: Cannot read property 'length' of undefined

options.hideTriggers is null instead of the default empty array. I tried setting it explicitly in my options but I still get the error. It looks like the culprit may be the previous call to the extend method in the prototype adapter:

options = (_ref = this.adapter).extend.apply(_ref, [{}].concat(__slice.call(optionSources)));

Let me know if you need more info. Thanks!

enyo commented 11 years ago

Thanks for your feedback. I really should have tested the prototype adapter a bit more... I'll look into it.

enyo commented 11 years ago

I'm really sorry for this, I thought that it was enough that all tests passed, and didn't test it in the browser. I added tests so that the stuff that got through wouldn't again.

I really shouldn't have released it without actually testing the prototype version at least once.

Thanks for pointing it out.

donlee8 commented 11 years ago

That was quick, thanks for the prompt fix!