enyo / opentip

Opentip is an open source javascript tooltip based on the protoype framework.
http://www.opentip.org
1.25k stars 401 forks source link

Issue while minifying the opentip.js file #15

Closed nowol closed 11 years ago

nowol commented 11 years ago

Hi,

I had an issue while trying to minify opentip.js using the Yui Compressor. I tracked it down with the help of the Yui Compressor maintainer to the use of the reserved keyword "char" in the dasherize method.

I was wondering if you could change the method dasherize from this:

Opentip::dasherize = (string) ->
  string.replace /([A-Z])/g, (_, char) -> "-#{char.toLowerCase()}"

To this:

Opentip::dasherize = (string) ->
  string.replace /([A-Z])/g, (_, character) -> "-#{character.toLowerCase()}"

Only "char" was renamed.

Thanks!

enyo commented 11 years ago

Thanks @nowol !

enyo commented 11 years ago

It'll be merged into the master branch and released as a version as soon as I implemented a few other things. So if you want to redownload it, please use the develop branch for now.

nowol commented 11 years ago

Thanks for the quick fix!