search

enyo / opentip

Opentip is an open source javascript tooltip based on the protoype framework.
http://www.opentip.org
1.25k stars 401 forks source link

Update css/opentip.css #28

Closed smoreau closed 11 years ago

smoreau commented 11 years ago

The text color and shadow of the tooltip should be applied on any sub element. For example, I used it with some HTML content and the h2 tags appear black instead of white with the dark style.

enyo commented 11 years ago

Thanks for the pull request. Unfortunately I can not merge it like this. Please read the CONTRIBUTING guidelines before submitting pull requests (this goes for all projects on github, if there is such a file). I just added the Stylus (CSS) section, but the information about sending pull requests to the develop branch was already there.

But: even if you do actually change the stylus file I'm not entirely sure I want to merge this your way... Isn't setting every child element like this a bit invasive? I think I prefer setting those values to inherit but have to figure out the browser support of this. What do you think?

smoreau commented 11 years ago

Oh, I didn't notice the CONTRIBUTING file and I didn't know you were using Stylus for building the css file. Sorry about that.

I am not sure about the inherit keyword. I think the keyword '!important' would be more appropriate here. The point of this change is to be sure everything under the tooltip is white as the background is dark. The way you want to implement it is up to you. :)