Contributor

[savagecarol]

Related Issue

• 42

Proposed changes

• make a function in about.dart from the api
• shifting of some file
• removal of unused code in main.dart

Description

• main.dart issues is also fixed
• theme file shifted in services folder
• about page is working perfectly

Screenshots

[savagecarol]

{ "login": "ashiscs", "id": 49238464, "node_id": "MDQ6VXNlcjQ5MjM4NDY0", "avatar_url": "https://avatars1.githubusercontent.com/u/49238464?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashiscs", "html_url": "https://github.com/ashiscs", "followers_url": "https://api.github.com/users/ashiscs/followers", "following_url": "https://api.github.com/users/ashiscs/following{/other_user}", "gists_url": "https://api.github.com/users/ashiscs/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashiscs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashiscs/subscriptions", "organizations_url": "https://api.github.com/users/ashiscs/orgs", "repos_url": "https://api.github.com/users/ashiscs/repos", "events_url": "https://api.github.com/users/ashiscs/events{/privacy}", "received_events_url": "https://api.github.com/users/ashiscs/received_events", "type": "User", "site_admin": false, "contributions": 1 },

there is no name field.... instead of that you can put avatar

[harry-hov]

Hey @savagecarol, you are doing great with your coding skills.

But one thing I would like to suggest is please also focus on your commit title and commit message.

[harry-hov]

there is no name field....

oh! Didn't knew that.

instead of that you can put avatar

If you want you can try adding avatar.

[harry-hov]

Also, please squash your commits in a single commit.

[savagecarol]

okay

[savagecarol]

avatar part is completed

[savagecarol]

i pushed the code on the --- contributor branch

[harry-hov]

Nicely done. Can you please squash all of your commits in a single commit.

[savagecarol]

okay cool

[savagecarol]

check it now

[savagecarol]

in my gitlog only one commit showing

[abhitidarbar]

in my gitlog only one commit showing

For now your pr is merged so that you can have start focusing on other issues but for next time keep in mind to squash your commit into single one .Also, try to use self explanatory commit messages about what that commit is all about rather than "all done". However ,your work and efforts are appreciated 👍 .