enzo-project / enzo-dev

The Enzo adaptive mesh-refinement simulation code.
Other
86 stars 94 forks source link

Openmp merge #237

Open cjllorente827 opened 9 months ago

cjllorente827 commented 9 months ago

name: Pull request about: Create a pull request to help us improve title: '' labels: '' assignees: ''


Thank you so much for your PR! To help us review, fill out the form to the best of your ability. Please make use of the development guide at https://enzo.readthedocs.io/en/latest/developer_guide/ModificationIntro.html#how-to-develop-enzo

Pull request summary

Provide a general summary of your changes in the title above, for example "Fixes crash in FluxCorrection between AMR levels". Please avoid non-descriptive titles such as "Addresses issue #42."

If you are able to do so, please do not create the PR out of main, but out of a separate branch.

Describe your pull request

Please provide at least 1-2 sentences describing the pull request in detail. Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here. Github will autolink if prefixed with a hash, e.g. #42.

If your PR depends on another PR, please link to the PR here github autolinking syntax.

[ ] This is a major change or addition. Will require two reviewers.

PR Checklist

Note that some of these check boxes may not apply to all pull requests.

Thank you!

We understand that PRs can sometimes be overwhelming, especially as the reviews start coming in. Please let us know if the reviews are unclear or the recommended next step seems overly demanding, or if you would like help in addressing a reviewer's comments. Lastly, please ping us if you've been waiting too long to hear back on your PR.

bwoshea commented 9 months ago

@cjllorente827 could you please (1) update the text of the PR to explain what you're doing with it, and (2) fix the code so it passes the tests? Thank you!

Edit: looking at the error messages it seems that you have a compilation problem. It should be easy to fix.