enzo1982 / BoCA

A component library used by the fre:ac audio converter
https://www.freac.org/
GNU General Public License v2.0
36 stars 9 forks source link

BoCA-1.1-alpha-20180306 does not compile on Linux Mint 18.3 #3

Closed wkremser closed 6 years ago

wkremser commented 6 years ago

This is the error i get trying to build the library:

make[3]: Entering directory '/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio' g++ -fvisibility=hidden -DBOCA_COMPONENT_BUILD -DHAVE_OLD_PARANOIA_INCLUDE=1 -I/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio/../../../include -fPIC -pthread -c cdio.cpp -o cdio.o g++ -fvisibility=hidden -DBOCA_COMPONENT_BUILD -DHAVE_OLD_PARANOIA_INCLUDE=1 -I/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio/../../../include -fPIC -pthread -c config.cpp -o config.o g++ -fvisibility=hidden -DBOCA_COMPONENT_BUILD -DHAVE_OLD_PARANOIA_INCLUDE=1 -I/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio/../../../include -fPIC -pthread -c info/cdinfo.cpp -o info/cdinfo.o g++ -fvisibility=hidden -DBOCA_COMPONENT_BUILD -DHAVE_OLD_PARANOIA_INCLUDE=1 -I/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio/../../../include -fPIC -pthread -c info/cdtext.cpp -o info/cdtext.o info/cdtext.cpp: In member function ‘smooth::Int BoCA::CDText::ReadCDText(const smooth::String&)’: info/cdtext.cpp:33:39: error: too few arguments to function ‘cdtext_t cdio_get_cdtext(CdIo_t, track_t)’ cdtext_t cdtext = cdio_get_cdtext(cd); ^ In file included from /usr/include/cdio/cdio.h:79:0, from info/cdtext.cpp:15: /usr/include/cdio/track.h:112:13: note: declared here cdtext_t cdio_get_cdtext (CdIo_t *p_cdio, track_t i_track); ^ info/cdtext.cpp:40:45: error: ‘CDTEXT_FIELD_PERFORMER’ was not declared in this scope cdInfo.SetArtist(cdtext_get_const(cdtext, CDTEXT_FIELD_PERFORMER, 0)); ^ info/cdtext.cpp:41:44: error: ‘CDTEXT_FIELD_TITLE’ was not declared in this scope cdInfo.SetTitle(cdtext_get_const(cdtext, CDTEXT_FIELD_TITLE, 0)); ^ ../../../Makefile-commands:88: recipe for target 'info/cdtext.o' failed make[3]: [info/cdtext.o] Error 1 make[3]: Leaving directory '/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder/cdio' Makefile:34: recipe for target 'cdio' failed make[2]: [cdio] Error 2 make[2]: Leaving directory '/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components/decoder' Makefile:14: recipe for target 'decoder' failed make[1]: [decoder] Error 2 make[1]: Leaving directory '/home/wkremser/Projects/freac-universe/BoCa/BoCA-1.1-alpha-20180306/components' Makefile:8: recipe for target 'all' failed make: [all] Error 2

These are the cdio packages installed on my system: libcdio-cdda-dev:amd64 0.83-4.2ubuntu1 libcdio-cdda1:amd64 0.83-4.2ubuntu1 libcdio-dev:amd64 0.83-4.2ubuntu1 libcdio-paranoia-dev:amd64 0.83-4.2ubuntu1 libcdio-paranoia1:amd64 0.83-4.2ubuntu1 libcdio13:amd64 0.83-4.2ubuntu1

enzo1982 commented 6 years ago

Please update your version of libcdio. You have version 0.83 from 2011 which is completely outdated. fre:ac requires at least version 0.90, released in 2012.

The current version of libcdio is version 2.0, released in December 2017.

It seems, however, that Debian (and thus Ubuntu and Mint) is stuck with version 0.83. Only Debian Buster and Ubuntu 18.04 will update to libcdio 1.0.

I will see if I can re-add support for older versions of libcdio, though, as the current Debian-based distributions will probably stay around for some time. It broke in the latest fre:ac release due to the addition of CD-Text support.

wkremser commented 6 years ago

First in english for everyone to read .. sorry, i didnt realise that my email response resulted in an response here on this ticket.

thx for that information.

i tried to compile fre:ac for myself because the alpha version of fre:ac tends to crash while loading the cd information.

my setup uses 4 cd drives connected to a intel nuc system running linux mit 18.3.

i wanted to check if a self compiled version of fre:ac produced the same crashes as the binary downloadable version for linux.

i can open a ticket in fre:ac with the stack traces i get if you like and we can close this issue here.

--- original answer in german ---

Ah ok, danke für die Infos ..

Ich hab versucht freac selber zu kompilieren, weil die alpha bei mir immer wieder abstürzt beim laden von cds. Ich verwende ein Setup mit 4 CD Laufwerken zum rippen und ein intel nuc system mit Linux Mint 18.3.

Bevor ich Fehlermeldungen zum Thema Abstürze schicke, wollte ich versuchen ob eine selbstkompilierte Version die Fehler behebt.

Falls ich doch die Stack Traces von den Abstürzen schicken soll, lassen Sie es mich bitte wissen.

LG Wolfgang Kremser

On 11 Apr 2018, at 14:12, Robert Kausch notifications@github.com wrote:

Please update your version of libcdio. You have version 0.83 from 2011 which is completely outdated. fre:ac requires at least version 0.90, released in 2012.

The current version of libcdio is version 2.0, released in December 2017.

It seems, however, that Debian (and thus Ubuntu and Mint) is stuck with version 0.83. Only Debian Buster and Ubuntu 18.04 will update to libcdio 1.0.

I will see if I can re-add support for older versions of libcdio, though, as the current Debian-based distributions will probably stay around for some time. It broke in the latest fre:ac release due to the addition of CD-Text support.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/enzo1982/BoCA/issues/3#issuecomment-380429945, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXf3RZqmUE9ZQUQm3fpo3-ijdRwcxNGks5tnfNIgaJpZM4TP3Us.

enzo1982 commented 6 years ago

Ja, ein Stack-Trace wäre nett. Evtl. kann ich damit die Ursache für die Abstürze ausfindig machen.

Die Datei cdtext.cpp ist jetzt aktualisiert, um ältere Versionen von libcdio zu unterstützten. Damit sollte das Kompilieren klappen:

https://github.com/enzo1982/BoCA/raw/master/components/decoder/cdio/info/cdtext.cpp

wkremser commented 6 years ago

Thx .. compilation succeeded now.

i will open a new issue in fre:ac with the stack traces soon.