enzo1982 / freac

The fre:ac audio converter project
https://www.freac.org/
GNU General Public License v2.0
1.43k stars 75 forks source link

Front covers seem corrupted during a convert #303

Closed GooodFr closed 2 years ago

GooodFr commented 2 years ago

Hello,

Describe the bug When I convert AAC files in MP3 files, my player can't see front covers

To Reproduce

  1. I have some AAC files

  2. Before, I added all Front covers in those files with Mp3tag v3.14

  3. Today, I would like to convert all my AAC file to MP3 I tried to do it with fre:ac v1.1.6

  4. When I check my new files with Mp3tag, I see my covers in MP3 files

  5. But I can't see them in my player (in my car) Usually, my car work fine with MP3 In my car, I see all my covers on MP3, but not on all fre:ac conversions

Expected behavior I expected to see covers in converted files

Additional context I don't know if that can help : With Mp3tag, I also tried to write covers.jpg, I see that sometime become (title) on some file names.</p> <p>Regards, and thank you so much for your work !</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/enzo1982"><img src="https://avatars.githubusercontent.com/u/7796713?v=4" />enzo1982</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Difficult to tell what's going wrong here. One possibility is that fre:ac is writing ID3v2.4 tags and your car player does not support those (many devices support only ID3v2.3).</p> <p>Please check the ID3v2 tag encoding setting on the Tags page in fre:ac's configuration dialog. It should be set to UTF-16LE. Setting it to UTF-16BE or UTF-8 will make fre:ac create ID3v2.4 tags.</p> <p>Another possibility is that your AAC files have the <em>Subtitle</em> tag field set. In that case, fre:ac will preserve that field during conversion and write it to the corresponding ID3v2 field. The subtitle field is available in ID3v2.4 only, though, so this will also trigger creation of the newer tag version. You can check the ID3v2 tag version with Mp3tag.</p> <p>If that doesn't explain it, it would be great if you could provide an example file. Ideally one version created with fre:ac and one where you added the cover with Mp3tag and it's showing up on your car player.</p> <p>If you cannot attach files here, you can send them to support@freac.org.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/GooodFr"><img src="https://avatars.githubusercontent.com/u/59373933?v=4" />GooodFr</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Thank you so much for you answer and all explains ! I'm so sorry, I think that I found my problem, and it's not from fre:ac I think that my problem come from the size or format of my covers ...</p> <p>But the problem with <title> is real in fre:ac </p> <title> used in covers.jpg that you generate, seem no support UTF-8 (that was Russian titles) Best regards ! </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>