enzo1982 / freac

The fre:ac audio converter project
https://www.freac.org/
GNU General Public License v2.0
1.39k stars 72 forks source link

freaccmd appimage ignores SIGINT prior to conversion start #354

Open mattaw opened 2 years ago

mattaw commented 2 years ago

Describe the bug After freaccmd is run a CTRL-C or SIGINT before the text Processing file: ./01 Hallowed.flac... is printed is ignored, and does not abort freaccmd.

Note: This could be a complexity from AppImage, and not freaccmd, I have seen similar questions around it. However it may be easy to test for.

To Reproduce Steps to reproduce the behavior:

  1. ./freac-continuous-linux-x86_64.AppImage freaccmd -e opus ./01\ Hallowed.flac -o foo.opus
  2. Hit CTRL-C before any text prints
  3. Processing file: ./01 Hallowed.flac... appears
  4. Conversion completes, printing done.

Expected behavior After CTRL-C abort and return aborted. and return a nonzero returncode.

System (please complete the following information)

Additional context Note: This may be caused by an interaction with AppImage. Perhaps freac is not handling a SIGINT forwarded to it before it is run by the exec in the bash script somehow? However if bash was given a SIGINT without a trap set, it would exit with a message so this seems wrong. Perhaps the AppImage never forwards the SIGINT?