search

enzo1982 / freac

The fre:ac audio converter project
https://www.freac.org/
GNU General Public License v2.0
1.33k stars 69 forks source link

Crash on CD attempted read #552

Open hawkiboy opened 8 months ago

hawkiboy commented 8 months ago

WIth CD mounted on desktop if I click on 'Add Audio CD Contents' freeac crashes. Same thing happens if I open freac then insert a CD while freac is frontmost app. I can go under file and add audio files which is very slow, but works and they convert just fine.

ninety7 commented 8 months ago

I'm experiencing the same issue, can convert by adding the CD via the Add Folder dialog, but this brings the wrong tag info. Here's part of the error report:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               freac [78350]
Path:                  /Applications/freac.app/Contents/MacOS/freac
Identifier:            org.freac.freac
Version:               1.1.7 (1.1.7.5891)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2023-11-09 10:41:09.4666 -0500
OS Version:            macOS 14.0 (23A344)
Report Version:        12
Anonymous UUID:        04532175-A4C7-8646-65F9-802A114A1BBE

Sleep/Wake UUID:       B912B290-B677-459E-86F7-DB09BC4850A5

Time Awake Since Boot: 300000 seconds
Time Since Wake:       7419 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Termination Reason:    Namespace SIGNAL, Code 6 Abort trap: 6
Terminating Process:   freac [78350]

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib                 0x180fbf11c __pthread_kill + 8
1   libsystem_pthread.dylib                0x180ff6cc0 pthread_kill + 288
2   libsystem_c.dylib                      0x180f06a50 abort + 180
3   libsystem_c.dylib                      0x180f05d6c __assert_rtn + 284
4   CoreFoundation                         0x181239624 CFDataGetBytes.cold.3 + 44
5   CoreFoundation                         0x1810d7068 CFDataGetBytes + 200
6   cdio.dylib                             0x105210ee8 0x105200000 + 69352
7   cdio.dylib                             0x1052032e4 get_discmode_cd_generic + 48
8   cdio.dylib                             0x1052104b4 0x105200000 + 66740
9   boca_deviceinfo_cdio.1.0.dylib         0x10a261f68 0x10a260000 + 8040
10  boca_deviceinfo_cdio.1.0.dylib         0x10a261c7c 0x10a260000 + 7292
11  freac.dylib                            0x104e8d300 0x104e0c000 + 529152
12  libsmooth-0.9.0.dylib                  0x10534fa00 0x105338000 + 96768
13  libsmooth-0.9.0.dylib                  0x1053513f0 0x105338000 + 103408
14  libsmooth-0.9.0.dylib                  0x105350d34 smooth::GUI::Widget::Process(int, int, int) + 912
15  libsmooth-0.9.0.dylib                  0x105350a8c smooth::GUI::Widget::Process(int, int, int) + 232
16  libsmooth-0.9.0.dylib                  0x105350a8c smooth::GUI::Widget::Process(int, int, int) + 232
17  libsmooth-0.9.0.dylib                  0x10537a1fc smooth::GUI::Window::Process(int, int, int) + 536
18  libsmooth-0.9.0.dylib                  0x10537b970 0x105338000 + 276848
19  libsmooth-0.9.0.dylib                  0x1053a3538 0x105338000 + 439608
20  AppKit                                 0x1853c5e24 _routeMouseUpEvent + 132
21  AppKit                                 0x1849d8b80 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 384
22  AppKit                                 0x1849d882c -[NSWindow(NSEventRouting) sendEvent:] + 284
23  AppKit                                 0x18507fc08 -[NSApplication(NSEventRouting) sendEvent:] + 1556
24  AppKit                                 0x184cd31bc -[NSApplication _handleEvent:] + 60
25  AppKit                                 0x1848a0460 -[NSApplication run] + 512
26  libsmooth-0.9.0.dylib                  0x1053a6f70 0x105338000 + 454512
27  libsmooth-0.9.0.dylib                  0x105392914 smooth::System::EventProcessor::ProcessNextEvent() + 40
28  libsmooth-0.9.0.dylib                  0x10534628c smooth::GUI::Application::Loop() + 152
29  freac.dylib                            0x104e8667c StartGUI + 16
30  freac                                  0x104bf7c5c 0x104bf4000 + 15452
31  dyld                                   0x180c7d058 start + 2224

Thread 1:
0   libsystem_kernel.dylib                 0x180fb9ea8 __semwait_signal + 8
1   libsystem_c.dylib                      0x180e9d4c4 nanosleep + 220
2   libsmooth-0.9.0.dylib                  0x105392d2c smooth::System::System::Sleep(unsigned int) + 64
3   freac.dylib                            0x104e7364c 0x104e0c000 + 423500
4   freac.dylib                            0x104e250c0 0x104e0c000 + 102592
5   libsmooth-0.9.0.dylib                  0x1053950c0 0x105338000 + 381120
6   libsmooth-0.9.0.dylib                  0x105394c78 smooth::Threads::Thread::MainCaller(smooth::Threads::Thread*) + 44
7   libsmooth-0.9.0.dylib                  0x1053a7e44 0x105338000 + 458308
8   libsystem_pthread.dylib                0x180ff7034 _pthread_start + 136
9   libsystem_pthread.dylib                0x180ff1e3c thread_start + 8

Thread 2:: com.apple.NSEventThread
0   libsystem_kernel.dylib                 0x180fb68b4 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x180fc8d30 mach_msg2_internal + 80
2   libsystem_kernel.dylib                 0x180fbf4f0 mach_msg_overwrite + 476
3   libsystem_kernel.dylib                 0x180fb6c38 mach_msg + 24
4   CoreFoundation                         0x1810d3ed0 __CFRunLoopServiceMachPort + 160
5   CoreFoundation                         0x1810d2798 __CFRunLoopRun + 1208
6   CoreFoundation                         0x1810d1c2c CFRunLoopRunSpecific + 608
7   AppKit                                 0x1849d68e0 _NSEventThread + 144
8   libsystem_pthread.dylib                0x180ff7034 _pthread_start + 136
9   libsystem_pthread.dylib                0x180ff1e3c thread_start + 8

Thread 3:
0   libsystem_pthread.dylib                0x180ff1e28 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib                0x180ff1e28 start_wqthread + 0

Thread 5:
0   libsystem_pthread.dylib                0x180ff1e28 start_wqthread + 0

Thread 6:
0   libsystem_pthread.dylib                0x180ff1e28 start_wqthread + 0

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000000   x2: 0x0000000000000000   x3: 0x0000000000000000
    x4: 0x0000000000000000   x5: 0x000000000000002e   x6: 0x0000600000697f40   x7: 0x0000000000000850
    x8: 0x79c271de61a309bd   x9: 0x79c271dfb988dabd  x10: 0x000000000000000a  x11: 0x0000000000000000
   x12: 0x0000000000000032  x13: 0x00000000001ff800  x14: 0x00000000000007fb  x15: 0x00000000c801085d
   x16: 0x0000000000000148  x17: 0x00000001e14ecdb8  x18: 0x0000000000000000  x19: 0x0000000000000006
   x20: 0x00000001d82bd300  x21: 0x0000000000000103  x22: 0x00000001d82bd3e0  x23: 0x00000001813e2796
   x24: 0x00000001d714e000  x25: 0x0000000000000033  x26: 0x0000000000000000  x27: 0x0000000000000114
   x28: 0x000000002bd80025   fp: 0x000000016b20aa00   lr: 0x0000000180ff6cc0
    sp: 0x000000016b20a9e0   pc: 0x0000000180fbf11c cpsr: 0x40001000
   far: 0x000000010bc5c000  esr: 0x56000080  Address size fault
ninety7 commented 8 months ago

I'm also happy to report that downgrading to 1.1.6 does not have this issue

johnkharvey commented 7 months ago

I see the same! Apple M1 16GB RAM Mac OS Ventura 13.4.1 (c)

Crash info:


Translated Report (Full Report Below)
-------------------------------------

Process:               freac [1138]
Path:                  /Applications/freac.app/Contents/MacOS/freac
Identifier:            org.freac.freac
Version:               1.1.7 (1.1.7.5891)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2023-11-12 17:28:48.5930 -0500
OS Version:            macOS 13.4.1 (22F770820d)
Report Version:        12
Anonymous UUID:        F2D32EEE-85D1-935A-EC49-584EFA25DC6E

Time Awake Since Boot: 480 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib                 0x1991a0724 __pthread_kill + 8
1   libsystem_pthread.dylib                0x1991d7c28 pthread_kill + 288
2   libsystem_c.dylib                      0x1990e5ae8 abort + 180
3   libsystem_c.dylib                      0x1990e4e44 __assert_rtn + 272
4   CoreFoundation                         0x199417db8 CFDataGetBytes.cold.3 + 40
5   CoreFoundation                         0x1992b9644 CFDataGetBytes + 332
6   cdio.dylib                             0x106e94ee8 0x106e84000 + 69352
7   cdio.dylib                             0x106e872e4 get_discmode_cd_generic + 48
8   cdio.dylib                             0x106e944b4 0x106e84000 + 66740
9   boca_deviceinfo_cdio.1.0.dylib         0x107371f68 0x107370000 + 8040
10  boca_deviceinfo_cdio.1.0.dylib         0x107371c7c 0x107370000 + 7292
11  freac.dylib                            0x10707d300 0x106ffc000 + 529152
12  libsmooth-0.9.0.dylib                  0x10314ba00 0x103134000 + 96768
13  libsmooth-0.9.0.dylib                  0x10314d3f0 0x103134000 + 103408
14  libsmooth-0.9.0.dylib                  0x10314cd34 smooth::GUI::Widget::Process(int, int, int) + 912
15  libsmooth-0.9.0.dylib                  0x10314ca8c smooth::GUI::Widget::Process(int, int, int) + 232
16  libsmooth-0.9.0.dylib                  0x10314ca8c smooth::GUI::Widget::Process(int, int, int) + 232
17  libsmooth-0.9.0.dylib                  0x1031761fc smooth::GUI::Window::Process(int, int, int) + 536
18  libsmooth-0.9.0.dylib                  0x103177970 0x103134000 + 276848
19  libsmooth-0.9.0.dylib                  0x10319f538 0x103134000 + 439608
20  AppKit                                 0x19cd20cc0 _routeMouseUpEvent + 132
21  AppKit                                 0x19c602f1c -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 384
22  AppKit                                 0x19c602bc8 -[NSWindow(NSEventRouting) sendEvent:] + 284
23  AppKit                                 0x19c601f0c -[NSApplication(NSEvent) sendEvent:] + 1556
24  AppKit                                 0x19c851fc4 -[NSApplication _handleEvent:] + 60
25  AppKit                                 0x19c4c9368 -[NSApplication run] + 500
26  libsmooth-0.9.0.dylib                  0x1031a2f70 0x103134000 + 454512
27  libsmooth-0.9.0.dylib                  0x10318e914 smooth::System::EventProcessor::ProcessNextEvent() + 40
28  libsmooth-0.9.0.dylib                  0x10314228c smooth::GUI::Application::Loop() + 152
29  freac.dylib                            0x10707667c StartGUI + 16
30  freac                                  0x102df7c5c 0x102df4000 + 15452
31  dyld                                   0x198e7ff28 start + 2236

Thread 1:
0   libsystem_kernel.dylib                 0x19919b50c __semwait_signal + 8
1   libsystem_c.dylib                      0x19907c2d0 nanosleep + 220
2   libsmooth-0.9.0.dylib                  0x10318ed2c smooth::System::System::Sleep(unsigned int) + 64
3   freac.dylib                            0x10706364c 0x106ffc000 + 423500
4   freac.dylib                            0x1070150c0 0x106ffc000 + 102592
5   libsmooth-0.9.0.dylib                  0x1031910c0 0x103134000 + 381120
6   libsmooth-0.9.0.dylib                  0x103190c78 smooth::Threads::Thread::MainCaller(smooth::Threads::Thread*) + 44
7   libsmooth-0.9.0.dylib                  0x1031a3e44 0x103134000 + 458308
8   libsystem_pthread.dylib                0x1991d7fa8 _pthread_start + 148
9   libsystem_pthread.dylib                0x1991d2da0 thread_start + 8

Thread 2:: com.apple.NSEventThread
0   libsystem_kernel.dylib                 0x199197f14 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x1991aa240 mach_msg2_internal + 80
2   libsystem_kernel.dylib                 0x1991a0b78 mach_msg_overwrite + 604
3   libsystem_kernel.dylib                 0x199198290 mach_msg + 24
4   CoreFoundation                         0x1992b67e4 __CFRunLoopServiceMachPort + 160
5   CoreFoundation                         0x1992b50c4 __CFRunLoopRun + 1208
6   CoreFoundation                         0x1992b44b8 CFRunLoopRunSpecific + 612
7   AppKit                                 0x19c600334 _NSEventThread + 172
8   libsystem_pthread.dylib                0x1991d7fa8 _pthread_start + 148
9   libsystem_pthread.dylib                0x1991d2da0 thread_start + 8

Thread 3:
0   libsystem_pthread.dylib                0x1991d2d8c start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib                0x1991d2d8c start_wqthread + 0

Thread 5:
0   libsystem_pthread.dylib                0x1991d2d8c start_wqthread + 0

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000000   x2: 0x0000000000000000   x3: 0x0000000000000000
    x4: 0x0000000000000000   x5: 0x000000000000002e   x6: 0x0000000000000000   x7: 0x0000000000000000
    x8: 0x06857eb383462d4e   x9: 0x06857eb2775d334e  x10: 0xcccccccccccccccd  x11: 0x000000000000000a
   x12: 0x0000000000000000  x13: 0x0000000000000032  x14: 0x00000000ffffffff  x15: 0x00000001f41cc5d8
   x16: 0x0000000000000148  x17: 0x00000001f8cd4f60  x18: 0x0000000000000000  x19: 0x0000000000000006
   x20: 0x00000001f41b1e00  x21: 0x0000000000000103  x22: 0x00000001f41b1ee0  x23: 0x00000001995bd972
   x24: 0x00000001f1862000  x25: 0x0000000000000033  x26: 0x0000000000000000  x27: 0x0000000000000104
   x28: 0x000000002bd80025   fp: 0x000000016d00aa30   lr: 0x00000001991d7c28
    sp: 0x000000016d00aa10   pc: 0x00000001991a0724 cpsr: 0x40001000
   far: 0x000000010bd64000  esr: 0x56000080  Address size fault

Binary Images:
       0x102df4000 -        0x102df7fff org.freac.freac (1.1.7) <eb818a27-bd18-34c4-8a4a-66057e879193> /Applications/freac.app/Contents/MacOS/freac`
JoeBarlow73 commented 7 months ago

I'm also having this issue, on an M3 Max MacBook Pro with 36 GB RAM, running Sonoma 14.1.1. I just upgraded from a 2019 Intel MacBook Pro, and had no issues on that system.

kokosowy commented 5 months ago

I can confirm this bug in most recent MacOS version. I needed to downgrade freac to v1.1.6 as well.

saftl commented 4 months ago

same issue here, v1.1.6 works

mattaw commented 2 months ago

Looks like some progress has been made in https://github.com/enzo1982/freac/issues/587#issuecomment-1937893757, so hopefully it will be rolled in when @enzo1982 gets around to his next patch cycle.