enzo1982 / mp4v2

Reviving the MP4v2 project...
https://mp4v2.org
Other
140 stars 52 forks source link

cmake check fails on Ubuntu 18.04 #21

Closed LaHaine closed 1 year ago

LaHaine commented 2 years ago

This is the output of cmake on Ubuntu 18.04 with cmake 3.10.2, trying to build git 347dab9504ab822315e3bb07b13473ea1fd579fe:

% cmake ..
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - found
-- Looking for include file stdint.h
-- Looking for include file stdint.h - found
-- Looking for include file stdio.h
-- Looking for include file stdio.h - found
-- Looking for include file stdlib.h
-- Looking for include file stdlib.h - found
-- Looking for include file string.h
-- Looking for include file string.h - found
-- Looking for include file sys/stat.h
-- Looking for include file sys/stat.h - found
-- Looking for include file sys/types.h
-- Looking for include file sys/types.h - found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of ((struct stat*)0)->st_size
-- Check size of ((struct stat*)0)->st_size - done
CMake Error at CMakeLists.txt:56 (math):
  math EXPR called with incorrect arguments.

-- Configuring incomplete, errors occurred!
See also "/tmp/mp4v2/build/CMakeFiles/CMakeOutput.log".

It is working fine with cmake 3.16.3 on Ubuntu 20.04.

enzo1982 commented 2 years ago

Thank you for reporting this!

This should be fixed with commit b42f531d which restores compatibility with CMake versions down to 3.0.0.

LaHaine commented 2 years ago

Indeed, it is fixed, thanks.

enzo1982 commented 1 year ago

The fix is included in MP4v2 v2.1.2 released just now.