enzoampil / fastquant

fastquant — Backtest and optimize your ML trading strategies with only 3 lines of code!
MIT License
1.48k stars 236 forks source link

Reopening of PR 363 #380

Open jbdelmundo opened 3 years ago

jbdelmundo commented 3 years ago

Reopening from PR 363

Description Added the following changes:

Checklist [ X] I am making a pull request from a branch other than master [ X] I have read the CONTRIBUTING.md [ X] I have added/edited documentation in a relevant docs/docusaurus markdown file [X ] (For new docs, check if not applicable) I have added the id of a new docs md to the docs/docusaurus/sidebars.js file

mikeejazmines commented 2 years ago

hi @jbdelmundo! Sorry for the delay, am reviewing your PR now but could you fix all the merge conflicts? I agree with the implementation and can merge this once the merge conflicts are fixed and when I'm done reviewing and testing everything else :)

Thanks so much!